Add RuboCop for code style enforcement

[nofaralfasi]

No description provided.

[stejskalleos]

TIL that we have hammer jenkins job as well, for some reason it's failing:

1.9.3/lib/ci/reporter/rake/minitest_loader.rb:9:in `<top (required)>': undefined method `runner=' for Minitest::Unit:Class (NoMethodError)
15:54:45 	from /usr/local/rvm/gems/ruby-2.7.4@test_hammer_cli_foreman_discovery_pull_request-0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:21:in `require'
15:54:45 	from /usr/local/rvm/gems/ruby-2.7.4@test_hammer_cli_foreman_discovery_pull_request-0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:21:in `block in <main>'
15:54:45 	from /usr/local/rvm/gems/ruby-2.7.4@test_hammer_cli_foreman_discovery_pull_request-0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:6:in `select'
15:54:45 	from /usr/local/rvm/gems/ruby-2.7.4@test_hammer_cli_foreman_discovery_pull_request-0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:6:in `<main>'

@ekohl is this something we can fix in this repo or it's a problem in the job itself?

[ekohl]

I suspect the version is too old to be compatible:

hammer-cli-foreman-discovery/Gemfile

Line 14 in cb036b6

gem 'ci_reporter', '>= 1.6.3', "< 2.0.0", :require => false

https://rubygems.org/gems/ci_reporter says the latest is 2.1.0

Having said that, we can ask ourselves if we still want ci_reporter. It's only used for reporting in a way that's usable in Jenkins while we're moving away from Jenkins for our CI. So I'd suggest to drop it and drop the Jenkins job in https://github.com/theforeman/jenkins-jobs.

[ekohl]

Another way to deal with this is to add it, but set the value to false.

[nofaralfasi]

That failed the tests...

[nofaralfasi]

Having said that, we can ask ourselves if we still want ci_reporter. It's only used for reporting in a way that's usable in Jenkins while we're moving away from Jenkins for our CI. So I'd suggest to drop it and drop the Jenkins job in https://github.com/theforeman/jenkins-jobs.

Opened theforeman/jenkins-jobs#428 for dropping jenkins jobs.

[stejskalleos]

Thanks @nofaralfasi @ekohl