Refs #38077 - Don't build hidden params as options #634
+7
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofedoren
force-pushed
the
refs-38077-param-with-show
branch
2 times, most recently
from
37b65af to
3471fcc
Compare
adamlazik1
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Can't comment on the code much but I tested it with theforeman/foreman#10322 and it works as intended.
Comment on lines
244
to
245
| # require 'pry-byebug'; binding.pry if associated_resource.to_s == "location" | ||
| # parent_show_from_api = ParamsNameFilter.new("#{aliased_name}_id").for_action(@resource.action(@context[:action].to_s)).first&.show? |
There was a problem hiding this comment.
Suggested change
| # require 'pry-byebug'; binding.pry if associated_resource.to_s == "location" | |
| # parent_show_from_api = ParamsNameFilter.new("#{aliased_name}_id").for_action(@resource.action(@context[:action].to_s)).first&.show? |
| options << family.parent( | ||
| optionamize("--#{aliased_name}-id"), | ||
| "#{aliased_name}_id".upcase, | ||
| description("#{aliased_name}_id", @context[:action]), | ||
| attribute_name: HammerCLI.option_accessor_name("#{resource_name}_id"), | ||
| referenced_resource: resource_name, | ||
| aliased_resource: aliased_name, | ||
| format: HammerCLI::Options::Normalizers::Number.new | ||
| format: HammerCLI::Options::Normalizers::Number.new, | ||
| # show: parent_show_from_api ? parent_show_from_api : true |
There was a problem hiding this comment.
Suggested change
| # show: parent_show_from_api ? parent_show_from_api : true |
ofedoren
force-pushed
the
refs-38077-param-with-show
branch
from
3471fcc to
1a88c77
Compare
ofedoren
force-pushed
the
refs-38077-param-with-show
branch
from
1a88c77 to
a7ff2ad
Compare
|
Oops, some debug leftovers, updated. Thanks, @adamlazik1 ! Since the PRs in Foreman and apipie-bindings got merged, could you please re-test it in case I missed something? |
adamlazik1
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Confirming that it works as intented.
Retested with hammer user-group external:
Before:
$ hammer user-group external create -h
Usage:
hammer user-group external create [OPTIONS]
Options:
--auth-source[-id] VALUE/NUMBER Name/id of linked authentication source
--location[-id|-title] VALUE/NUMBER Set the current location context for the request
--name VALUE External user group name
--organization[-id|-title] VALUE/NUMBER Set the current organization context for the request
--user-group[-id] VALUE Name/id or name of user group
-h, --help Print help
After:
$ hammer user-group external create -h
Usage:
hammer user-group external create [OPTIONS]
Options:
--auth-source[-id] VALUE/NUMBER Name/id of linked authentication source
--name VALUE External user group name
--user-group[-id] VALUE Name/id or name of user group
-h, --help Print help
The repository in unit tests needs to be reverted before merging. Just putting it here so it is not forgotten.
ofedoren
force-pushed
the
refs-38077-param-with-show
branch
from
a7ff2ad to
e3563f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
@adamlazik1, you might be interested in this, since it tries to use your changes in theforeman/foreman#10322.
Note: this PR includes test data from Foreman 3.14 API docs, generated using theforeman/foreman#10322.