Skip to content

Commit

Permalink
Drop Smart Proxy plugin testing
Browse files Browse the repository at this point in the history
All plugins have been converted to GitHub Actions and this cleans up the
remains.
  • Loading branch information
ekohl committed Nov 29, 2024
1 parent 491b285 commit 30112e3
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 160 deletions.
19 changes: 0 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,25 +78,6 @@ Current PR test jobs (used on Foreman itself) support these commands:
* `ok to test` - run tests for an unknown user, if the code within the patch is not malicious
* `[test STATUS-NAME]`, e.g. `[test foreman]` to re-run a particular set of tests

## Quick reference for plugin maintainers

### Smart proxy plugin testing

Proxy plugins are tested like ordinary gems with tests run entirely from the plugin directory, installing the smart proxy as a dependency (via bundler's git support).

To add testing for a plugin `smart_proxy_example` do the following:

* ensure plugin tests run when doing `bundle install` and `rake test`, see [testing a plugin](https://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Smart-Proxy_Plugin#Testing) for help
* if different branches rely on different versions of smart proxy, specify `:branch` in Gemfile on those branches
* add the project in [theforeman.org/yaml/jobs/smart-proxy-plugin.yaml](https://github.com/theforeman/jenkins-jobs/tree/master/theforeman.org/yaml/jobs/smart-proxy-plugin.yaml) to create a `smart-proxy-example-test` job in Jenkins to test the master branch.
* add the project in [theforeman.org/yaml/jobs/smart-proxy-plugin-pr-test.yaml](https://github.com/theforeman/jenkins-jobs/tree/master/theforeman.org/yaml/jobs/tests/smart-proxy-plugin-pr-test.yaml) to create a `smart_proxy_example-pr-test` job in Jenkins to test PRs.
* ensure the job is green by fixing bugs, installing dependencies etc.
* add hook to GitHub repo, see [GitHub repo hook](#testing-develop)

An org admin must then:

* add the repo to the [Bots team](https://github.com/orgs/theforeman/teams/bots/repositories) with **write** access

# Foreman's Other Tests

Jenkins is not the only place tests are defined and executed.
Expand Down
18 changes: 0 additions & 18 deletions theforeman.org/yaml/builders/smart-proxy-plugin.yaml

This file was deleted.

41 changes: 0 additions & 41 deletions theforeman.org/yaml/jobs/smart-proxy-plugin-pull-request.yaml

This file was deleted.

50 changes: 0 additions & 50 deletions theforeman.org/yaml/jobs/smart-proxy-plugin.yaml

This file was deleted.

32 changes: 0 additions & 32 deletions theforeman.org/yaml/jobs/tests/smart-proxy-plugin-pr-test.yaml

This file was deleted.

0 comments on commit 30112e3

Please sign in to comment.