Remove Verify Version and Release from Pulp Packaging

[Odilhao]

We removed this from Pulpcore with #236 , now we have rpm/develop as well on pulpcore-packaging, addning another condition to verify the version only for foreman-packaging

[ekohl]

Why is this check not needed on Pulp? It ensures you properly increase versions and that they are built correctly.

[Odilhao]

In the past we had problem with cherrypicks that updated the version and carried one or two bumps, this would make this step of the pipeline fail.
And right now we have this PR theforeman/pulpcore-packaging#737 that is bumping createrepo_c and I'm not sure why it fails here, we already have the build done here.

[ekohl]

In the past we had problem with cherrypicks that updated the version and carried one or two bumps, this would make this step of the pipeline fail.

But you you shouldn't do cherry picks for rpm/develop, so that's irrelevant.

And right now we have this PR theforeman/pulpcore-packaging#737 that is bumping createrepo_c and I'm not sure why it fails here, we already have the build done here.

The reason is fails is that the spec creates two python3-createrepo_c:

[2023-11-06T19:31:35.790Z] + rpmspec -q --srpm --undefine=dist --undefine=foremandist '--queryformat=%{VERSION}' packages/createrepo_c/createrepo_c.spec
[2023-11-06T19:31:35.791Z] error: line 123: %package -n python3-createrepo_c: package python3-createrepo_c already exists
[2023-11-06T19:31:35.791Z] error: query of specfile packages/createrepo_c/createrepo_c.spec failed, can't parse

I can reproduce this on a minimal CentOS 8 Stream container:

$ podman run -it --rm -v .:/packaging:Z centos:stream8
# dnf install /usr/bin/rpmspec
# cd packaging/
# rpmspec -q --srpm --undefine=dist --undefine=foremandist '--queryformat=%{VERSION}' packages/createrepo_c/createrepo_c.spec
error: line 137: %package -n python3-createrepo_c: package python3-createrepo_c already exists
error: query of specfile packages/createrepo_c/createrepo_c.spec failed, can't parse

The reason is here:

# grep '%package -n' packages/createrepo_c/createrepo_c.spec
%package -n python%{python3_pkgversion}-%{name}
%package -n python3-%{name}
# rpm -E '%{python3_pkgversion}'
3

So both statements evaluate to the same package name. It doesn't know about modules to be enabled, so that's why it fails.

I think theforeman/pulpcore-packaging#737 (comment) is a better solution that to disable the checks.

[ekohl]

Given the checks phase now passes for theforeman/pulpcore-packaging#737, can we close this?

[Odilhao]

Thanks for the help in the PR