Use artifacts from the upstream job, if possible #382
Conversation
We've seen multiple times that a package release job runs, but doesn't use the latest source. My theory is that there's a race condition between declaring the last source release job as last successful and the package release job running. The Copy Artifact Plugin has an option for the selector[1]. That can be set to upstream with a fallback to the last successful. That would mean that when a source release job triggers a package release job, the triggering job is the upstream. If there is none (like with a manual run), then it should fall back to the last successful. [1]: https://www.jenkins.io/doc/pipeline/steps/copyartifact/
Now that I investigate it, this isn't right. https://ci.theforeman.org/job/foreman-installer-develop-package-release/1576/ was triggered by https://ci.theforeman.org/job/foreman-installer-develop-source-release/1657/ and it also states:
And if I look in the tarball that 1657 uses, then it has the correct changes included (I checked Yet theforeman/puppet-pulpcore#315 (comment) proves nightly didn't. Also, the resulting SRPM from https://ci.theforeman.org/job/foreman-installer-develop-package-release/1576/ has the correct changes (again, checked So We can also see that https://ci.theforeman.org/job/foreman-nightly-rpm-pipeline/2098/ synced it and included the change (and passed). Yet on https://yum.theforeman.org/nightly/el8/x86_64/ I see https://yum.theforeman.org/nightly/el8/x86_64/foreman-installer-3.9.0-0.3.develop.20231123031245gite0bf154.el8.noarch.rpm so somehow it's not being synced from staging to release. In sosreport I could also see it was installing the old package |
We've seen multiple times that a package release job runs, but doesn't use the latest source. My theory is that there's a race condition between declaring the last source release job as last successful and the package release job running.
The Copy Artifact Plugin has an option for the selector. That can be set to upstream with a fallback to the last successful. That would mean that when a source release job triggers a package release job, the triggering job is the upstream. If there is none (like with a manual run), then it should fall back to the last successful.
I'm unsure about the syntax, but https://stackoverflow.com/questions/53820503/how-to-copy-artifacts-from-other-jenkins-job-from-a-pipeline/53821560#53821560 suggests the
selector: upstream()part is correct and I'm assuming the option is passed this way.