inject foreman version for stable plugin builds #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows to have the same plugin version to have different builds for different foreman releases, thus making it possible to cleanly upgrade to plugin builds that match the foreman release even if there are no plugin version differences. practical example: foreman_puppet 6.2.0 exists in 3.8, 3.9, 3.10 and nightly, but in 3.10 and nightly it needs to be built with Webpack5 and not 3 to work. before this change, all builds ended up being 6.2.0-1 and apt would not consider to upgrade those when coming from 3.9 to 3.10, creating a broken setup. with this change, the versions would be: 6.2.0-1~fm3.8 6.2.0-1~fm3.9 6.2.0-1~fm3.10 6.2.0-1 which apt will gladly upgrade in that order It would be cool if we could name the last one 6.2.0-1~3.11, but there is no way for us to know that the next version will be 3.11 at that point
ehelms
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows to have the same plugin version to have different builds for different foreman releases, thus making it possible to cleanly upgrade to plugin builds that match the foreman release even if there are no plugin version differences.
practical example: foreman_puppet 6.2.0 exists in 3.8, 3.9, 3.10 and nightly, but in 3.10 and nightly it needs to be built with Webpack5 and not 3 to work.
before this change, all builds ended up being 6.2.0-1 and apt would not consider to upgrade those when coming from 3.9 to 3.10, creating a broken setup.
with this change, the versions would be:
6.2.0-1~fm3.86.2.0-1~fm3.96.2.0-1~fm3.106.2.0-1which apt will gladly upgrade in that order
It would be cool if we could name the last one 6.2.0-1~3.11, but there is no way for us to know that the next version will be 3.11 at that point