Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop centos8-stream support from pipelines #474

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver commented Jun 3, 2024

Updated pipeline configuration in theforeman.org/pipelines/vars/katello/ and theforeman.org/pipelines/vars/foreman/ to drop support for centos8-stream due to CentOS 8 EOL

Dropped centos8-stream support and added AlmaLinux support for candlepin in theforeman.org/pipelines/vars/candlepin and pulpcore in theforeman.org/pipelines/vars/pulpcore.

@ekohl ekohl linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In itself it looks ok for Foreman & Katello, but I'd prefer to deal with Candlepin & Pulpcore in the same commit.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add almalinux9 where you added almalinux8 as well. That way we're consistently testing it in the same way everywhere.

Comment on lines 6 to 7
'centos9-stream',
'almalinux8'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't done before, but I prefer trailing commas so you can easily add other things later.

@archanaserver archanaserver force-pushed the drop-centos8-stream branch from 3467077 to 9d82093 Compare June 4, 2024 08:26
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit 7744549 into theforeman:master Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch pipelines to using Alma
2 participants