-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop centos8-stream support from pipelines #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In itself it looks ok for Foreman & Katello, but I'd prefer to deal with Candlepin & Pulpcore in the same commit.
30a3c96
to
3467077
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add almalinux9
where you added almalinux8
as well. That way we're consistently testing it in the same way everywhere.
'centos9-stream', | ||
'almalinux8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't done before, but I prefer trailing commas so you can easily add other things later.
3467077
to
9d82093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updated pipeline configuration in theforeman.org/pipelines/vars/katello/ and theforeman.org/pipelines/vars/foreman/ to drop support for
centos8-stream
due to CentOS 8 EOLDropped centos8-stream support and added AlmaLinux support for candlepin in theforeman.org/pipelines/vars/candlepin and pulpcore in theforeman.org/pipelines/vars/pulpcore.