Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use main instead of master for hammer-cli-katello #482

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 12, 2024

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Jul 12, 2024

cc @ianballou

should we also rename the jobs to say main? (will require some changes in packaging too then)

@ekohl
Copy link
Member

ekohl commented Jul 12, 2024

Why did katello move to the main branch? Couldn't it have chosen develop?

@evgeni
Copy link
Member Author

evgeni commented Jul 12, 2024

🤷‍♀️

I only update to match https://github.com/Katello/hammer-cli-katello/branches and thus make things work again.

Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl I think main was chosen because it is what Github changed its default to. Your comment around develop is fair as an ecosystem decision but it's something we've never fully articulated as a thing we should standardize around. I think this could be worth a discourse post and update to developer docs.

@ehelms ehelms merged commit 32eb252 into master Jul 12, 2024
2 checks passed
@ehelms ehelms deleted the hammer-katello-main branch July 12, 2024 20:55
@evgeni
Copy link
Member Author

evgeni commented Jul 13, 2024

@ekohl I think main was chosen because it is what Github changed its default to. Your comment around develop is fair as an ecosystem decision but it's something we've never fully articulated as a thing we should standardize around. I think this could be worth a discourse post and update to developer docs.

Ian did ask on Matrix some time ago, and we recommended develop for consistency ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants