Only show scenario options when multiple are available #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the option to disable and enable scenarios when there's only a single one available. That assumes the scenario is already enabled. If there is only one, there is also no reason to switch scenarios. That makes force and compare not needed. The --scenario and --list-scenarios are kept in because instructions can refer to an explicit scenario. That keeps the installation manual consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the option to disable and enable scenarios when there's only a single one available. That assumes the scenario is already enabled.
If there is only one, there is also no reason to switch scenarios. That makes force and compare not needed.
The --scenario and --list-scenarios are kept in because instructions can refer to an explicit scenario. That keeps the installation manual consistent.
This is completely untested, but it's here to illustrate the point I made in https://github.com/theforeman/kafo/pull/280/files#r499792034.