Support passing array commands to format_command #374
Merged
+55
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
support-passing-array-commands
branch
from
82036c8 to
6ee0d3c
Compare
evgeni
previously approved these changes
Oct 18, 2024
evgeni
reviewed
Oct 18, 2024
The use of an array with Open3 spawns a process directly without a shell which removes the need to escape values for a shell.
ekohl
force-pushed
the
support-passing-array-commands
branch
from
6ee0d3c to
ddecdbe
Compare
evgeni
reviewed
Oct 18, 2024
evgeni
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of an array with Open3 spawns a process directly without a shell which removes the need to escape values for a shell.