Respect build_dir from resource

[ehelms]

No description provided.

[ekohl]

Wouldn't this technically be equal to:

Suggested change

	self.class.build_path(File.join(resource[:hostname], file_name), resource[:build_dir])
	super(File.join(resource[:hostname], file_name))

[ehelms]

I believe so, and could be considered as a re-factor to code that I'd do as a follow up across a few files.

[ekohl]

I see a few places where self.build_path is called. We should get rid of those.

[ehelms]

Yes, there is an over-use of self throughout that I would tackle as a re-factor after I do some other clean up first.

[ekohl]

I also did some of that when I tried to understand this PR. I think #418 is at least one clean up that can already happen.

[ehelms]

For example, I can now rip out all of the RPM generation and handling code since we've been running based on just the files from a deployment stand-point for a few release now. And that may end up cleaning out a lot of code. So I'd revisit re-factor after I do that.

[ehelms]

@ekohl Good with this change and saving the some of the re-factoring for some follow on work?

[ekohl]

I was trying to get rid of the static method, but the inheritance does make it hard. I think there is one case that still uses it:

puppet-certs/lib/puppet/provider/ca/katello_ssl_tool.rb

Lines 56 to 58 in 027e2cb

	def self.privkey(name)
	build_path("#{name}.key")
	end

Wouldn't that part fail after merging this?

[ehelms]

I was trying to get rid of the static method, but the inheritance does make it hard. I think there is one case that still uses it:

puppet-certs/lib/puppet/provider/ca/katello_ssl_tool.rb

Lines 56 to 58 in 027e2cb

	def self.privkey(name)
	build_path("#{name}.key")
	end

Wouldn't that part fail after merging this?

You would think, but tests are passing. I do not see anything calling the class method so I'll remove it.