Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pki_dir structure only if deploy #417

Closed
wants to merge 1 commit into from
Closed

Create pki_dir structure only if deploy #417

wants to merge 1 commit into from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Sep 22, 2023

Contains / requires -- #416

@ehelms ehelms requested a review from ekohl September 25, 2023 22:57
@ehelms
Copy link
Member Author

ehelms commented Oct 10, 2023

@ekohl could you review?

@ekohl ekohl mentioned this pull request Nov 7, 2023
Closed
@ekohl
Copy link
Member

ekohl commented Nov 7, 2023

It took me a while to get to this, but I think the design could be slightly different. The biggest issue that I see is that every concrete class (qpid, puppet, foreman, etc) can deploy. In that case $certs::deploy may be false while $certs::foreman::deploy may be true.

I've opened #436 but I'm not 100% sure it is correct either.

@ehelms ehelms closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl Awaiting requested review from ekohl

Assignees
No one assigned
Labels
Enhancement Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehelms @ekohl