Copy the server CA certificate with file resource #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
force-pushed
the
copy-server-ca
branch
4 times, most recently
from
8b0001a
to
cbce2fb
Compare
ekohl
reviewed
Sep 25, 2023
ehelms
force-pushed
the
copy-server-ca
branch
2 times, most recently
from
8626dae
to
c3c2eb4
Compare
evgeni
reviewed
Mar 26, 2024
| @@ -54,7 +54,6 @@ | |||
| Stdlib::Absolutepath $pki_dir = $certs::pki_dir, | |||
| Optional[Stdlib::Absolutepath] $server_cert = $certs::server_cert, | |||
| Optional[Stdlib::Absolutepath] $server_key = $certs::server_key, | |||
| Optional[Stdlib::Absolutepath] $server_cert_req = $certs::server_cert_req, | |||
There was a problem hiding this comment.
Why was that ever needed? (curious-Evgeni is afraid of the answer)
There was a problem hiding this comment.
I am not sure --
seems symbolic
evgeni
reviewed
Mar 26, 2024
evgeni
reviewed
Mar 26, 2024
ehelms
force-pushed
the
copy-server-ca
branch
2 times, most recently
from
8a33911
to
08b7c0e
Compare
|
I think this is simpler and more straight forward now. |
evgeni
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code required to make the server CA certificate which is either just a copy of the default CA or the supplied custom CA certificate from a user.
The current implementation requires the server CA certificate in the
build_dirdue to how we generate the tarball for Capsules.Stay tuned for further enhancements, for now this is a small step simplification.