Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the server CA certificate with file resource #420

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Sep 23, 2023

This simplifies the code required to make the server CA certificate which is either just a copy of the default CA or the supplied custom CA certificate from a user.

The current implementation requires the server CA certificate in the build_dir due to how we generate the tarball for Capsules.

Stay tuned for further enhancements, for now this is a small step simplification.

@ehelms ehelms force-pushed the copy-server-ca branch 4 times, most recently from 8b0001a to cbce2fb Compare September 25, 2023 00:29
@@ -54,7 +54,6 @@
Stdlib::Absolutepath $pki_dir = $certs::pki_dir,
Optional[Stdlib::Absolutepath] $server_cert = $certs::server_cert,
Optional[Stdlib::Absolutepath] $server_key = $certs::server_key,
Optional[Stdlib::Absolutepath] $server_cert_req = $certs::server_cert_req,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was that ever needed? (curious-Evgeni is afraid of the answer)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure --

FileUtils.cp(resource[:custom_req], build_path(File.basename(req_file)))
seems symbolic

manifests/apache.pp Outdated Show resolved Hide resolved
manifests/apache.pp Outdated Show resolved Hide resolved
@ehelms ehelms force-pushed the copy-server-ca branch 2 times, most recently from 8a33911 to 08b7c0e Compare March 26, 2024 14:15
@ehelms
Copy link
Member Author

ehelms commented Mar 26, 2024

I think this is simpler and more straight forward now.

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I acked that one already, but seems not

@ehelms ehelms merged commit 18bd669 into theforeman:master Apr 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants