Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop RPMs from being included in tarball #421

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Sep 24, 2023

These were kept in for N-1 support when we first switched away from using RPMs for deployment. Enough release have passed that we can drop this.

@ehelms
Copy link
Member Author

ehelms commented Oct 10, 2023

@ekohl could you take a look?

@evgeni
Copy link
Member

evgeni commented Mar 21, 2024

The RPMs are still built and everything, right? Just not distributed in the certs-tar?

(README needs an update, it says the deployment still uses RPM, but that's unrelated to the changes in this PR)

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending my understanding of the change ("build but don't tar/distribute the rpms") is correct, ack

@ehelms ehelms merged commit 39713ae into theforeman:master Mar 21, 2024
9 checks passed
@ehelms
Copy link
Member Author

ehelms commented Mar 21, 2024

The RPMs are still built and everything, right? Just not distributed in the certs-tar?

Correct -- #426 is designed to remove all RPM generation and simplify the code quite a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants