Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlmaLinux 8 & 9 support #254

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

archanaserver
Copy link
Contributor

Added AlmaLinux 8 and 9 to the supported operating systems in metadata.json.

These changes ensure that we start testing with AlmaLinux 8 and 9 instead of CentOS 8 Stream. This update is part of our transition to better support AlmaLinux in our Puppet modules.

See, for details: theforeman/foreman-infra#2087

@ekohl
Copy link
Member

ekohl commented Jun 6, 2024

This fails because of the PIDFile issue. You may notice we don't test on CentOS 8 because of that reason.

@archanaserver
Copy link
Contributor Author

This fails because of the PIDFile issue. You may notice we don't test on CentOS 8 because of that reason.

@ekohl what do you mean by PIDFile issue? it is unclear for me.

@ekohl
Copy link
Member

ekohl commented Jul 12, 2024

If you look for pidfile in the repository you'll find:

pidfile_workaround: 'CentOS'

This input is sent to https://github.com/voxpupuli/puppet_metadata

@archanaserver
Copy link
Contributor Author

If you look for pidfile in the repository you'll find:

pidfile_workaround: 'CentOS'

This input is sent to https://github.com/voxpupuli/puppet_metadata

@ekohl this supports array right, can we not do it this way, thought i don't understand the boolean part of it.
pidfile_workaround: 'CentOS,AlmaLinux'

@ehelms
Copy link
Member

ehelms commented Jul 16, 2024

@ekohl this supports array right, can we not do it this way, thought i don't understand the boolean part of it.
pidfile_workaround: 'CentOS,AlmaLinux'

Take a look at https://github.com/voxpupuli/puppet_metadata/blob/7c7dcad9f71cc873cd2cbffd608f635a2602d081/HISTORY.md?plain=1#L10

This is saying that you can set pidfile_workaround to true|false and apply it for all OSes. Or you can supply an array of specific OSes that the workaround should be applied to. Try setting

pidfile_workaround: 'CentOS'
to an array with CentOS and AlmaLinux in it.

Added AlmaLinux 8 and 9 to the supported operating systems in metadata.json.

These changes ensure that we start testing with AlmaLinux 8 and 9 instead
of CentOS 8 Stream. This update is part of our transition to better support
AlmaLinux in our Puppet modules.

See, for details: theforeman/foreman-infra#2087
@archanaserver
Copy link
Contributor Author

Done @ehelms

@ekohl ekohl merged commit cd18865 into theforeman:master Jul 16, 2024
18 checks passed
@archanaserver archanaserver deleted the add-alma branch July 17, 2024 04:08
@archanaserver
Copy link
Contributor Author

Thanks @ehelms @ekohl for helping me ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants