Add domains and subnets as puppet resources that interact with the Foreman API

[rjemanuele]

This will add support for creating domains and subnets within Foreman using Foreman's API from Puppet.

This also adds the ability to lookup IDs for some values with a "search=" string.

foreman_domain { "test.example.com":
      ensure          => present,
      base_url        => $foreman::foreman_url,
      consumer_key    => $foreman::oauth_consumer_key,
      consumer_secret => $foreman::oauth_consumer_secret,
      effective_user  => $foreman::oauth_effective_user,
      ssl_ca          => $foreman::server_ssl_chain,
      dns_id          => "search=$lower_fqdn",
    }

foreman_subnet { "192.168.1.0":
      ensure          => present,
      base_url        => $foreman::foreman_url,
      consumer_key    => $foreman::oauth_consumer_key,
      consumer_secret => $foreman::oauth_consumer_secret,
      effective_user  => $foreman::oauth_effective_user,
      ssl_ca          => $foreman::server_ssl_chain,
      network_type    => 'IPv4',
      network         => "192.168.1.0",
      cidr            => 24,
      mask            => "255.255.255.0",
      domain_ids      => [ "search=test.example.com" ],
      dhcp_id         => "search=$lower_fqdn",
      tftp_id         => "search=$lower_fqdn",
      httpboot_id     => "search=$lower_fqdn",
      dns_id          => "search=$lower_fqdn",
      bmc_id          => "search=$lower_fqdn",
}

[ekohl]

Looks like CI didn't ran. Could you rebase?

[ekohl]

@rjemanuele I'd still be interested in getting this in. Could you rebase this?

[rjemanuele]

Rebased :)

[ekohl]

Some minor comments, but otherwise I think this looks good.

[ekohl]

I think this creates some redundancy. We already have request which accepts a params hash so if anything this should pass search as a hash. That properly escapes it.

[rjemanuele]

@ekohl is there an example of using request I could have a look at to test with and make sure this works with it?

[jhoblitt]

There are some examples of using #request in its spec coverage: https://github.com/theforeman/puppet-foreman/blob/master/spec/unit/foreman_resource_rest_v3_spec.rb#L64-L131

[ekohl]

If you're not reusing these (and it looks like you're not), it's better to inline them.

[rjemanuele]

Can you help me out here with what you're looking for? I'm more of a C, C++, Python programmer, very new to Ruby.

[jhoblitt]

The request is to move the methods being generated by PuppetX::Foreman::Common::FOREMAN_DOMAIN_PARAMS directly into this file on the foreman_domain type instead of the extra layer of meta-programming since there isn't another type which will reuse these methods.

[jhoblitt]

Stated another way, the methods in lib/puppet_x/foreman/common.rb should be moved into foreman_*/rest_v3.rb.

[ekohl]

This can also be inlined, like domain.

[jhoblitt]

@rjemanuele Are you planning to take this over the finish line? I'm interested in these types as well.

[rjemanuele]

@jhoblitt Sure, I'll get this cleaned up and ready in the next week.

[jhoblitt]

@rjemanuele Great. Let me know if plans change and I'll try to pickup the ball.

[jhoblitt]

@rjemanuele Are you still stuck?

[jhoblitt]

@rjemanuele ping