fix foreman_rex_cockpit acceptance test #1205
Conversation
WTH |
| @@ -1,11 +1,10 @@ | |||
| require 'spec_helper_acceptance' | |||
|
|
|||
| describe 'Scenario: install foreman with rex cockpit', if: os[:family] == 'centos' do | |||
| describe 'Scenario: install foreman with rex cockpit', if: os[:family] == 'redhat' do | |||
There was a problem hiding this comment.
I thought the os thing was a bit weird because I think it comes from serverspec, which has a different interpretation for family. Maybe we should avoid it in general.
There was a problem hiding this comment.
it is weird already because it's downcased, yes. no idea where it comes from.
There was a problem hiding this comment.
There was a problem hiding this comment.
Wait, that's os, not family. https://github.com/mizzy/specinfra/tree/master/lib/specinfra/helper/detect_os is used for the family. https://github.com/mizzy/specinfra/blob/master/lib/specinfra/helper/detect_os/redhat.rb tells me that family is redhat, unless it's fedora or amazon.
Guess I just made an assumption given Debian/Ubuntu is different: https://github.com/mizzy/specinfra/blob/master/lib/specinfra/helper/detect_os/debian.rb
Package removals on RPMs are weird. I got the impression it always tried to sort of reverse the transaction instead of recalculating the dependency tree. |
1. the family is called `redhat`, not `centos` 2. to apply a manifest, you need to define `manifest` not `pp`
evgeni
force-pushed
the
fix-cockpit-test
branch
from
5758225 to
84e5c46
Compare
|
Any idea why DNF thinks it wants to remove |
grub2-tools-minimal gets installed when we install cockpit, and uninstalling foreman tries to uninstall grub2-tools-minimal as there are no more dependencies on it, but that fails as it's a protected package given this is only a test setup in a container, we don't care about grub at all and can safely purge it again
redhat, notcentosmanifestnotpp