Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add packit #341

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add packit #341

merged 1 commit into from
Dec 17, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 13, 2024

No description provided.

@theforeman theforeman deleted a comment from packit-as-a-service bot May 13, 2024
@theforeman theforeman deleted a comment from packit-as-a-service bot May 13, 2024
@evgeni evgeni force-pushed the packit branch 4 times, most recently from f3d0898 to eb4e714 Compare May 13, 2024 10:17
@theforeman theforeman deleted a comment from packit-as-a-service bot May 13, 2024
@evgeni evgeni marked this pull request as draft May 13, 2024 11:23
@ehelms
Copy link
Member

ehelms commented May 13, 2024

Cool idea!

@ekohl
Copy link
Member

ekohl commented May 13, 2024

As I said on Matrix, if we go this route then I think we should prioritize theforeman/kafo#343 because it really cuts down on the CPU time spent by a lot. Previously it wasn't as big of an issue, but with packit it gets bigger.

@evgeni
Copy link
Member Author

evgeni commented Dec 16, 2024

note from team discussion: can packit be triggered on demand (comment or so), instead of always building

@evgeni evgeni marked this pull request as ready for review December 16, 2024 13:42
jobs:
- job: copr_build
trigger: pull_request
manual_trigger: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl @ehelms a tiny bolean making it all just work like we want :)

@evgeni
Copy link
Member Author

evgeni commented Dec 16, 2024

/packit build

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but otherwise 👍

.packit.yaml Outdated Show resolved Hide resolved
@evgeni evgeni enabled auto-merge (rebase) December 17, 2024 17:28
@evgeni evgeni merged commit 8875517 into master Dec 17, 2024
23 checks passed
@evgeni evgeni deleted the packit branch December 17, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants