enc.rb: Switch from legacy to structured facts #53
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
networking.fqdn is the successor. Manual verification:
```
irb(main):001:0> require 'facter'
=> true
irb(main):002:0> puts Facter.value('networking.fqdn')
puppet.local
=> nil
irb(main):003:0>
```
bastelfreak
commented
Dec 16, 2024
| @@ -202,7 +202,7 @@ def build_body(certname,filename) | |||
|
|
|||
| begin | |||
| require 'facter' | |||
| puppet_facts['values']['puppetmaster_fqdn'] = Facter.value(:fqdn).to_s | |||
| puppet_facts['values']['puppetmaster_fqdn'] = Facter.value('networking.fqdn').to_s | |||
There was a problem hiding this comment.
I also don't see a benefit in the .to_s, but it was there before, so we should probably keep it.
evgeni
approved these changes
Dec 16, 2024
ekohl
approved these changes
Dec 16, 2024
ekohl
reviewed
Dec 16, 2024
bastelfreak
added a commit
to bastelfreak/puppet-puppetserver_foreman
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networking.fqdn is the successor. Manual verification: