Use the smart_proxy_plugin.yml reusable GHA workflow #34
+4
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is largely the same as test-gem, except it verifies that it at least implements support for Ruby versions that the Smart Proxy wants. It also implements the version selector by respecting SMART_PROXY_BRANCH in the Gemfile.
By using GitHub Actions we no longer need Jenkins.
When there are multiple workflows this could cancel unexpected ones.
|
@ekohl I think you see the failing tests here as well, in this case it looks like problems with the unit tests? |
|
That's the result of Drop Jenkins integration in tests. I could leave it out until we merge theforeman/jenkins-jobs#506. |
|
Well you are the specialist, i am fine with it, i leave it up to you. We could also merge despite the failing tests. Or did you mean exactly that? |
|
I'll wait a bit to see about the other repos. I'm leaning to merging them all at the same time and then clean up Jenkins. Then we can merge this while ignoring the failing tests because the check will disappear on the next PR. |
evgeni
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely the same as test-gem, except it verifies that it at least implements support for Ruby versions that the Smart Proxy wants. It also implements the version selector by respecting SMART_PROXY_BRANCH in the Gemfile.
Also cleans up Jenkins bits and updates the license tag.