Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak Pulp Nightly pipelines #329

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Unbreak Pulp Nightly pipelines #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_stage_repository
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def comps(collection, version, dist, foreman_version):
repo = 'candlepin-packaging'
elif collection == 'pulpcore':
repo = 'pulpcore-packaging'
branch = version
branch = 'develop' if version == 'nightly' else version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't branch = 'develop' if foreman_version == 'nightly' else foreman_version from above do the same already, and we woulnd't have to set branch here at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulpcore was not getting the right version, it was using the foreman_version, after adding
branch = version it started to try to fetch the comps in the brach nightly that does not exist

https://ci.theforeman.org/blue/organizations/jenkins/pulpcore-nightly-rpm-pipeline/detail/pulpcore-nightly-rpm-pipeline/92/pipeline

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ad4f67c fixed pipelines that are not on develp/nightly


if collection == 'client' and dist == 'el7':
dist = 'rhel7'
Expand Down