-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRASH: Cannot find module 'typescript' #882
Comments
Hey @zburke, Thank you soooo much for taking the time to report this! @jnicklas @dagda1 Not gracefully handling the options when users do not select typescript is something that keeps coming up again and again. It seems we should have a separate integration test where we set up and run a TS project and also setup and run a JS project to make sure both pathways are secured. |
I can reproduce this when working with a freshly generated sample app as well, after upgrading the bigtest version. The sample app workaround is to install typescript. I'll open a PR as a stopgap. |
Add typescript and pin bigtest version. Partially addresses #882
Oh yes, definitely shoddy that we have not crossed this off. I have known about it. #679 is one issue also where we either include the rollup typescript plugin when there is no typescript or we suppress that particular error message. You could suppress it potentially through a custom rollup plugin which are pretty lightweight to create. |
Add typescript and pin bigtest version. Partially addresses #882
Error Report
Following the instructions at https://frontside.com/bigtest/docs/platform:
This can be resolved by
but since I answered "no" to "Do you want to write your tests in TypeScript?" that seems odd.
NB: The helpful-looking "Copy" button next to all the console instructions is slightly less helpful than it could be because it copies the leading
$
, which you have to remove.diagnostics
Argv
server,--launch=chrome
Stack
Error: Cannot find module 'typescript'
Require stack:
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at Object.typescript [as default] (/Users/zburke/temp/e2e/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:29168:36)
at prepareInputOptions (/Users/zburke/temp/e2e/node_modules/@bigtest/bundler/dist/bundler.js:51:48)
at prepareWatchOptions (/Users/zburke/temp/e2e/node_modules/@bigtest/bundler/dist/bundler.js:86:12)
at Bundler.watch (/Users/zburke/temp/e2e/node_modules/@bigtest/bundler/dist/bundler.js:113:37)
at watch.next ()
at /Users/zburke/temp/e2e/node_modules/effection/dist/effection.js:1:7739
The text was updated successfully, but these errors were encountered: