Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - sample app dependencies #884

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Bugfix - sample app dependencies #884

merged 1 commit into from
Mar 8, 2021

Conversation

jenweber
Copy link
Collaborator

@jenweber jenweber commented Mar 4, 2021

Add typescript and pin bigtest version.

Partially addresses #882

Motivation

I ran into two issues with a freshly generated sample app.

First, I got selector is not a function when using createInteractor. My sample app had bigtest 0.7.0 installed, which lacks the new syntax for interactors.

Second, I saw #882 after updating my bigtest dependency.

Approach

  • Pin the version of bigtest in app-pkg. An alternative would be to set it in the lockfiles only, but that seems easy to forget.
  • Add typescript as a temporary dependency. This can be removed when CRASH: Cannot find module 'typescript' #882 is resolved. This is a stopgap to make sure the main quickstart tutorial is back in working shape ASAP.

After merging

This needs to be released after merging.

@minkimcello please feel free to push to this branch or create another PR if you have a different approach.

@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2021

⚠️ No Changeset found

Latest commit: 39623e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jenweber jenweber requested a review from minkimcello March 4, 2021 06:21
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021

A preview package of this pull request has been published with the tag jw-fix-sample-app.
You can try it out by running the following command:

$ npm install bigtest-sample@jw-fix-sample-app

or by updating your package.json to:

{
  "bigtest-sample": "jw-fix-sample-app"
}

Generated by 🚫 dangerJS against 39623e9

@cowboyd
Copy link
Member

cowboyd commented Mar 4, 2021

It looks like they updated chrome version on the circle images. I'll need to push a fix, and then we'll have to rebase this.

@minkimcello
Copy link
Contributor

minkimcello commented Mar 4, 2021

I can't seem to replicate the typescript error on my end off of a fresh sample app install. 🤔

Add typescript and pin bigtest version.

Partially addresses #882
@jenweber jenweber force-pushed the jw-fix-sample-app branch from a60d52c to 39623e9 Compare March 8, 2021 05:13
@cowboyd cowboyd merged commit b6eb28f into v0 Mar 8, 2021
@cowboyd cowboyd deleted the jw-fix-sample-app branch March 8, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants