Reintroduce package-lock.json and update dependencies of sample app #899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To address the lockfile confusion and publish some of the dependency fix/changes. Right now, if you were to run
npx bigtest-sample
with its current dependencies, you will get a chromedriver error, parcel/babel error, and a typescript error.Approach
parcel
needs to be downgraded and locked in to1.12.3
because of parcel #5943bigtest
bumped up to0.13.3
to include the chromedriver fixpackage-lock.json
file at the root of the sample package to undo Remove accidental lockfile #898. We need bothpackage-lock.json
andyarn.lock
insample/
andsample/app/
because:yarn.lock
but npm@7 needs to be installed locally. It comes withnode >=15
but users wanting to use the sample app will be required to upgrade their node engines locally. So the safer bet would be to offer both npm and yarn solutions for now until we fully migrate to npm Migrate to npm@7 #681 (and maybe even after we migrate to npm Including both yarn and npm lock files in the sample app #889).TODOs