Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce package-lock.json and update dependencies of sample app #899

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

minkimcello
Copy link
Contributor

@minkimcello minkimcello commented Mar 9, 2021

Motivation

To address the lockfile confusion and publish some of the dependency fix/changes. Right now, if you were to run npx bigtest-sample with its current dependencies, you will get a chromedriver error, parcel/babel error, and a typescript error.

Approach

  • parcel needs to be downgraded and locked in to 1.12.3 because of parcel #5943
  • bigtest bumped up to 0.13.3 to include the chromedriver fix
  • We haven't published the sample package since Bugfix - sample app dependencies #884 which includes the typescript dependency so anyone that's trying to download and use the sample app now will be getting the typescript error (if they use npm)
  • Reintroduce the package-lock.json file at the root of the sample package to undo Remove accidental lockfile #898. We need both package-lock.json and yarn.lock in sample/ and sample/app/ because:
    • npm@7 will recognize and use yarn.lock but npm@7 needs to be installed locally. It comes with node >=15 but users wanting to use the sample app will be required to upgrade their node engines locally. So the safer bet would be to offer both npm and yarn solutions for now until we fully migrate to npm Migrate to npm@7 #681 (and maybe even after we migrate to npm Including both yarn and npm lock files in the sample app #889).

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2021

⚠️ No Changeset found

Latest commit: 173498d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@minkimcello minkimcello requested a review from cowboyd March 9, 2021 18:19
@minkimcello minkimcello changed the title Reintroduce package-lock.json and update dependencies Reintroduce package-lock.json and update dependencies to sample Mar 9, 2021
@minkimcello minkimcello changed the title Reintroduce package-lock.json and update dependencies to sample Reintroduce package-lock.json and update dependencies of sample app Mar 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

A preview package of this pull request has been published with the tag mk_add-lock-back.
You can try it out by running the following command:

$ npm install bigtest-sample@mk_add-lock-back

or by updating your package.json to:

{
  "bigtest-sample": "mk_add-lock-back"
}

Generated by 🚫 dangerJS against 173498d

@minkimcello minkimcello merged commit 5ae8a44 into v0 Mar 12, 2021
@minkimcello minkimcello deleted the mk/add-lock-back branch March 12, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants