Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linking of @bigtest/eslint-plugin rule to docs #804

Closed
wants to merge 3 commits into from

Conversation

dagda1
Copy link
Contributor

@dagda1 dagda1 commented Feb 1, 2021

While looking at #801 I remembered that there actually was an eslint rule for this.

The linking to the docs for the @bigtest/require-default-export is broken.

Eslint borks if it cannot find the definition.

This PR fixes it.

Maybe we should generate an eslint.json file as part of bigtest init?

@dagda1 dagda1 requested a review from cowboyd February 1, 2021 11:27
@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2021

🦋 Changeset detected

Latest commit: e3c017e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigtest/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

A preview package of this pull request has been published with the tag fix-eslint-links.
You can try it out by running the following command:

$ npm install @bigtest/eslint-plugin@fix-eslint-links

or by updating your package.json to:

{
  "@bigtest/eslint-plugin": "fix-eslint-links"
}

Generated by 🚫 dangerJS against e3c017e

@dagda1
Copy link
Contributor Author

dagda1 commented Feb 1, 2021

closing in favour of #807

@dagda1 dagda1 closed this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant