Validate test implementation in validate-test #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6434917 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A preview package of this pull request has been published with the tag $ npm install @bigtest/suite@validate-test-objector by updating your package.json to: {
"@bigtest/suite": "validate-test-object"
} |
dagda1
force-pushed
the
validate-test-object
branch
from
74446f8 to
8ffcba2
Compare
jnicklas
reviewed
Feb 4, 2021
jnicklas
reviewed
Feb 4, 2021
dagda1
force-pushed
the
validate-test-object
branch
from
8ffcba2 to
cf2c980
Compare
dagda1
force-pushed
the
validate-test-object
branch
from
69ea1c3 to
61294a8
Compare
jnicklas
reviewed
Feb 5, 2021
packages/suite/src/validate-test.ts
Outdated
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| function ensureIsTest (test: any, path: string[] = [], file?: string): test is Test { | ||
| if(!test) { | ||
| throw new TestValidationError("contains no description.\n\nDoes the test file contain a default export?", path, file) |
There was a problem hiding this comment.
I think this error message should not mention description?
jnicklas
reviewed
Feb 5, 2021
packages/suite/src/validate-test.ts
Outdated
| } | ||
|
|
||
| if(!test?.children || !test?.assertions) { | ||
| throw new TestValidationError('contains no assertions or children.'); |
There was a problem hiding this comment.
Can we have these as separate, more specific errors?
jnicklas
approved these changes
Feb 7, 2021
|
The CI build should be fixed now, could you rebase this? |
dagda1
force-pushed
the
validate-test-object
branch
from
9f93ac5 to
caa935a
Compare
rebased and gone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #801 where a malformed test file resulted in a meaningless error message.
This PR verifies (in
validate-test) that a test object must haveDescriptive errors are thrown if either of the above is not true.