Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Backfill the scoped() API to v3 #964

Merged
merged 1 commit into from
Jan 20, 2025
Merged

✨ Backfill the scoped() API to v3 #964

merged 1 commit into from
Jan 20, 2025

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Jan 20, 2025

Motivation

Allow v3 users to "upgrade" to the "scoped" API.

call() and action() are the ways to establish concurrency boundaries and error handling boundaries in v3, but they are getting simplified and losing those capabilities (it's a good thing!) However, in order to make the upgrade seemless, we want to have a backfill that let's you use the scoped API before you switch the version of Effection to 4.

Approach

This wraps call() which has the same function signature, and copies over its jsdoc so that the scoped() intellisense will be available in IDEs

Allow v3 users to "upgrade" to the "scoped" API.

`call()` and `action()` are the ways to establish concurrency
boundaries and error handling boundaries in v3, but they are getting
simplified and losing those capabilities (it's a good thing!) However,
in order to make the upgrade seemless, we want to have a backfill that
let's you use the scoped API _before_ you switch the version of
Effection to 4.

This wraps `call()` which has the same function signature, and copies
over its jsdoc so that the `scoped()` intellisense will be available
in IDEs
@cowboyd cowboyd requested review from taras, neurosnap and jbolda January 20, 2025 10:06
@cowboyd cowboyd merged commit a4de07c into v3 Jan 20, 2025
5 checks passed
@cowboyd cowboyd deleted the v3-scoped branch January 20, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants