Run tests in CI for Node 18, 20, 22 #966
Merged
+161
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taras
changed the title
cowboyd
reviewed
Jan 22, 2025
cowboyd
reviewed
Jan 22, 2025
There was a problem hiding this comment.
This is a major enhancement in our coverage, awesome!
Since we now are running the full test suite including maint.test.ts in NodeJS, I think we can get rid of the test:node task in deno.json and the corresponding .mjs file which just ensured that the main() function worked, but nothing else.
|
@cowboyd Repurposed node:test but I removed the node.mjs file. |
cowboyd
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I found a bug when running Effection v4 in Node 18 that was not there in Node 20. I tracked it to
toReversed. I wanted to fix it but I found that we don't actually run tests in Node.Approach