Make this site embeddable into another #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way fresh works it uses "clean" urls, relative paths don't really work. This gets rid of all "basing" elements and uses absolute urls which are relative to the root of this site. Since we're rebasing on the consuming edge, this is fine. In the future, we'll use directory urls for everything.
cowboyd
force-pushed
the
cl/make-embeddable
branch
from
04561a0 to
73b72bb
Compare
cowboyd
force-pushed
the
cl/make-embeddable
branch
from
73b72bb to
c6b17df
Compare
cowboyd
force-pushed
the
cl/make-embeddable
branch
from
c6b17df to
4c3a271
Compare
cowboyd
force-pushed
the
cl/make-embeddable
branch
from
4c3a271 to
8629a5e
Compare
taras
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Because of the way fresh works it uses "clean" urls, relative paths don't really work.
Approach
This gets rid of all "basing" elements and uses absolute urls which are relative to the root of this site. Since we're rebasing on the consuming edge, this is fine.
In the future, we'll use directory urls for everything.