Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on @bigtest/performance #59

Closed
wants to merge 1 commit into from
Closed

Conversation

cherewaty
Copy link
Collaborator

Motivation

thefrontside/bigtest#1006 (comment)

Approach

Remove the polyfill, since interactors are browser-only anyway.

After merge

Update sample app dependencies. The dev process for that part of this repo doesn't feel great, since with its own lock files it doesn't fit in the monorepo workflows.

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2021

🦋 Changeset detected

Latest commit: 340ddad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@interactors/html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 10, 2021

✔️ Deploy Preview for interactors canceled.

🔨 Explore the source changes: 340ddad

🔍 Inspect the deploy log: https://app.netlify.com/sites/interactors/deploys/613f566930f9350007ff1d67

@cherewaty
Copy link
Collaborator Author

@cowboyd you sure we can just switch to window.performance? Am I missing something obvious here re: environments?

@cowboyd
Copy link
Member

cowboyd commented Sep 16, 2021

@cherewaty Yup, it's just ponyfills for each environment: https://github.com/thefrontside/bigtest/blob/v0/packages/performance/package.json#L6

You can see the browser ponyfill just pulls them off globalThis https://github.com/thefrontside/bigtest/blob/v0/packages/performance/browser-ponyfill.js

You may want to use globalThis instead of window as that seems to be the preferred nomenclature these days.

GitHub
Ensure your React/Vue/Ember/anything app works perfectly across browsers. - bigtest/package.json at v0 · thefrontside/bigtest
GitHub
Ensure your React/Vue/Ember/anything app works perfectly across browsers. - bigtest/browser-ponyfill.js at v0 · thefrontside/bigtest

@cherewaty
Copy link
Collaborator Author

Replaced by #73

@cherewaty cherewaty closed this Sep 16, 2021
@cherewaty cherewaty deleted the performance branch September 16, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants