Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation Simulator #277

Merged
merged 44 commits into from
Jul 19, 2024
Merged

Foundation Simulator #277

merged 44 commits into from
Jul 19, 2024

Conversation

jbolda
Copy link
Contributor

@jbolda jbolda commented Jun 3, 2024

Motivation

We want to improve the ability to iteratively build a simulator for use in published simulators in this repository or custom implementations elsewhere. This includes the components likely to be used in each simulator (server, router, data store) and pieces to enable quickly spinning up a simulator to get started.

Approach

@frontsidejack
Copy link
Member

frontsidejack commented Jun 3, 2024

Package Changes Through e23e781

There are 1 changes which include @simulacrum/foundation-simulator with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@simulacrum/foundation-simulator 0.0.1 0.1.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@jbolda jbolda added the preview label Jun 3, 2024
@frontsidejack
Copy link
Member

frontsidejack commented Jun 5, 2024

The following preview packages have been published by Covector:

e23e781

@cowboyd
Copy link
Member

cowboyd commented Jun 6, 2024

I had a brief look over the code. I think having some tests that demonstrate how you would use the foundation simulator Api, and especially how you would interact with the store would serve as good documentation, as well as a quality control.

Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I don't see why we shouldn't iterate forward on this. Sorry it took so long get to, but if customers are using this happily, it looks like way more direction and guardrails than we had before.

@jbolda jbolda marked this pull request as ready for review July 19, 2024 21:40
@jbolda jbolda merged commit b10ba9e into main Jul 19, 2024
4 checks passed
@jbolda jbolda deleted the foundation-simulator branch July 19, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants