Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source fields in RiaH mapping view #61

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

janblom
Copy link

@janblom janblom commented Jan 7, 2025

Underlying problem was that the class MappingPanel handles both table -> table and field -> field mappings, since they are higly similar. Recently some functionality was added that should only apply to tables (hiding tables from the view), but it affected the field -> field views as well.
This was fixed by making the MappingPanel class aware of the type of mapping it was handling (between tables or between fields).
A test was added to confirm this. Since the RiaH tests take a significant amount of time, the tests were moved to the verification phase (use mvn verify to run them).

@Spayralbe
Copy link

Spayralbe commented Jan 13, 2025

Haven't reviewed the code changes yet, but one thing I noticed when using the app is that the source fields are now indeed visible (as expected) when entering a field to field mapping view, but they are still hidden when exporting the specifications as mapping docs (any format).

riah_source_fields_hidden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants