Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heatmap #1162

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Update heatmap #1162

merged 2 commits into from
Feb 25, 2024

Conversation

WeilerP
Copy link
Member

@WeilerP WeilerP commented Feb 22, 2024

Bug fixes

  • Subset genes specified in gene_order to ones for which a model has been fit.

Closes

Closes #1161.

Subset genes specified in `gene_order` to ones for which a model has
been fit.
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (9e71e13) to head (9ce3a7d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   80.62%   80.62%           
=======================================
  Files          51       51           
  Lines        8491     8492    +1     
  Branches     2218     2219    +1     
=======================================
+ Hits         6846     6847    +1     
  Misses       1103     1103           
  Partials      542      542           
Files Coverage Δ
src/cellrank/pl/_heatmap.py 96.13% <100.00%> (+0.01%) ⬆️

Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WeilerP !

@michalk8 michalk8 added the misc PR fixes something arbitrary label Feb 23, 2024
@michalk8
Copy link
Collaborator

Unfortunately, I can't merge this because I can't force merge (don't have the maintainer rights) and scvi tools needs requests and for some reason it's not required by them.

@WeilerP WeilerP merged commit 7c8b9d4 into theislab:main Feb 25, 2024
7 of 9 checks passed
@WeilerP WeilerP deleted the fix/gene_order_in_heatmap branch February 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc PR fixes something arbitrary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that genes to plot in heatmap exist
2 participants