Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtol for scipy iterative solver, bump version #1237

Merged
merged 6 commits into from
Dec 14, 2024
Merged

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Dec 3, 2024

closes #1235

@michalk8 michalk8 added the bug Something isn't working label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.41%. Comparing base (82248b2) to head (3a4f159).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   79.47%   79.41%   -0.07%     
==========================================
  Files          51       51              
  Lines        8604     8603       -1     
  Branches     2251     1489     -762     
==========================================
- Hits         6838     6832       -6     
- Misses       1193     1195       +2     
- Partials      573      576       +3     
Files with missing lines Coverage Δ
src/cellrank/_utils/_linear_solver.py 40.32% <100.00%> (-0.32%) ⬇️

... and 2 files with indirect coverage changes

@michalk8 michalk8 changed the title Fix rtol for sciPy iterative solver, bump version Fix rtol for scipy iterative solver, bump version Dec 3, 2024
@michalk8 michalk8 merged commit bf27c94 into main Dec 14, 2024
7 of 10 checks passed
@michalk8 michalk8 deleted the fix/gmres-tol branch December 14, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: gmres() got an unexpected keyword argument 'tol'
1 participant