Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #765
There are some cons atm:
These are the two classes I am talking about:
With the GENOT implementation
GENOTLinProblem
tries to inherit a class that requirespush/pull
moscot/src/moscot/problems/generic/_generic.py
Line 779 in f84f8be
pros:
Less ignore comments for mypy
Less code
Better understanding of the expected attributes and methods
Things to do: