Skip to content

Commit

Permalink
Update node version to 20 (#1237)
Browse files Browse the repository at this point in the history
  • Loading branch information
thekevinscott authored Oct 17, 2023
1 parent d5eb1c6 commit 77f4cfd
Show file tree
Hide file tree
Showing 11 changed files with 32 additions and 48 deletions.
24 changes: 12 additions & 12 deletions .github/actions/setup-pnpm/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@ runs:
version: 8
run_install: false

# - name: Get pnpm store directory
# shell: bash
# run: |
# echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

# - uses: actions/cache@v3
# name: Setup pnpm cache
# with:
# path: ${{ env.STORE_PATH }}
# key: ${{ runner.os }}-${{ inputs.node-version }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
# restore-keys: |
# ${{ runner.os }}-${{ inputs.node-version }}-pnpm-store-
- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- uses: actions/cache@v3
name: Setup pnpm cache
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-${{ inputs.node-version }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-${{ inputs.node-version }}-pnpm-store-
- name: Install dependencies
shell: bash
Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Lint'
run: 'pnpm lint'
Expand All @@ -39,7 +39,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Unit Tests / Vite'
working-directory: ./packages/upscalerjs
Expand All @@ -64,7 +64,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Unit Tests / Playwright'
working-directory: ./packages/upscalerjs
Expand All @@ -90,7 +90,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Unit Tests'
working-directory: ./packages/upscalerjs
Expand All @@ -114,7 +114,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Unit Tests'
working-directory: ./packages/shared
Expand All @@ -132,7 +132,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Unit Tests'
working-directory: ./internals
Expand Down Expand Up @@ -169,7 +169,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

# - name: Setup tmate session
# uses: mxschmitt/action-tmate@v3
Expand All @@ -194,7 +194,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Integration Tests'
run: pnpm test:integration:clientside
Expand All @@ -213,7 +213,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

# - name: Setup tmate session
# uses: mxschmitt/action-tmate@v3
Expand All @@ -238,7 +238,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

# - name: Setup tmate session
# uses: mxschmitt/action-tmate@v3
Expand All @@ -259,7 +259,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Integration Tests'
run: pnpm test:integration:model:serverside
Expand All @@ -276,7 +276,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

- name: 'Memory Leak Tests'
run: pnpm test:integration:memory-leaks
Expand All @@ -293,7 +293,7 @@ jobs:
- name: 'Setup PNPM with Node 16'
uses: ./.github/actions/setup-pnpm
with:
node-version: 16
node-version: 20

# - name: Setup tmate session
# uses: mxschmitt/action-tmate@v3
Expand Down
2 changes: 1 addition & 1 deletion internals/bundlers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
}
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"devDependencies": {
"@types/ejs": "^3.1.2",
Expand Down
2 changes: 1 addition & 1 deletion internals/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@
"test": "wireit"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
}
}
2 changes: 1 addition & 1 deletion internals/http-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"test": "wireit"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"devDependencies": {
"wireit": "latest",
Expand Down
2 changes: 1 addition & 1 deletion internals/test-runner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"test": "wireit"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"devDependencies": {
"wireit": "latest",
Expand Down
2 changes: 1 addition & 1 deletion internals/upscaler-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@
"test": "vitest"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
}
}
2 changes: 1 addition & 1 deletion internals/webdriver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"test": "wireit"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"devDependencies": {
"wireit": "latest",
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
"fast-folder-size": "2.2.0",
"fs-extra": "11.1.1",
"glob": "^10.3.3",
"heapdump": "0.3.15",
"inquirer": "9.2.10",
"jest": "29.6.3",
"jest-canvas-mock": "2.5.2",
Expand Down
15 changes: 0 additions & 15 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@upscalerjs/scripts",
"private": true,
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"scripts": {
"__run_command": "ts-node --esm --project ./tsconfig.json"
Expand Down

0 comments on commit 77f4cfd

Please sign in to comment.