Skip to content

Commit

Permalink
Some deepsource complaints
Browse files Browse the repository at this point in the history
  • Loading branch information
thekevinscott committed Sep 14, 2023
1 parent b4a300e commit e46997c
Show file tree
Hide file tree
Showing 13 changed files with 215 additions and 220 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export class EsbuildBundler extends Bundler {
port = 0;
packages = PACKAGES;

get name() {
get name() { // skipcq: JS-0105
return 'esbuild bundler';
}

Expand Down
2 changes: 1 addition & 1 deletion internals/bundlers/src/bundlers/node/src/NodeBundler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class NodeBundler extends Bundler {
port = 0;
packages = PACKAGES;

get name() {
get name() { // skipcq: JS-0105
return 'node bundler';
}

Expand Down
2 changes: 1 addition & 1 deletion internals/bundlers/src/bundlers/umd/src/UMDBundler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class UMDBundler extends Bundler {
port = 0;
usesRegistry = false;

get name() {
get name() { // skipcq: JS-0105
return 'umd bundler';
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class WebpackBundler extends Bundler {
port = 0;
packages = PACKAGES;

get name() {
get name() { // skipcq: JS-0105
return 'webpack bundler';
}

Expand Down
2 changes: 1 addition & 1 deletion internals/bundlers/src/utils/Bundler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class Bundler {
this.outDir = outDir;
}

get name(): string {
get name(): string { // skipcq: JS-0105
throw new Error("Extend this class and implement the name getter");
}

Expand Down
Loading

0 comments on commit e46997c

Please sign in to comment.