Deep recursion postfix patterns #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also completes the PR #29, solves the same problem. |
retoo
force-pushed
the
deep-recursion-postfix-patterns
branch
from
1fc8bd7 to
59f711e
Compare
|
@anthonycorbacho I already resolved the conflict this PR, please merge the Pull Request #70 first, afterwards you can merge this one (which then should have no conflict). |
The Postfix grok patterns have been downloaded from https://github.com/whyscream/postfix-grok-patterns/blob/f0ec34dcc6250463a30ba2077d8afa89ee1a17a1/postfix.grok Refs Graylog2/graylog2-server#3949
retoo
force-pushed
the
deep-recursion-postfix-patterns
branch
from
59f711e to
e4c9547
Compare
|
@anthonycorbacho strange; no idea why it didn't work. Anyway, now it's rebased. |
|
Awesome thanks !! |
|
@anthonycorbacho Would it be possible to get a release of java-grok with this fix? |
|
@anthonycorbacho yes please! @joschi you can use the jetpack.io distribution if you like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the tests from #67 and fixes #66
Grok/compile aborts now if a definition cannot be resolved.
@anthonycorbacho I have no idea often this might break actual setups. The unit tests are green ;)