Added configuration parameter grpc.port to make the gRPC server port configurable #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzvoncek
requested changes
Nov 25, 2024
| @@ -158,6 +158,7 @@ backup_grace_period_in_days = 10 | |||
| ; Set to true when running in grpc server mode. | |||
| ; Allows to propagate the exceptions instead of exiting the program. | |||
| ;enabled = False | |||
| ;port = <grpc port the server listens to. Defaults to port 50051.> | |||
There was a problem hiding this comment.
@alberto-bortolan , could you please add this same thing to the medusa-example.ini file in the root of the project?
There was a problem hiding this comment.
@rzvoncek done it
|
rzvoncek
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds one parameter to the
[grpc]section inmedusa.ini:port: grpc port the server listens to. Defaults to 50051This change resolves #512 (grpc service - port number configurability) on the Medusa side.
Other projects such as k8ssandra-operator will need changes to support the new parameter.