Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style update #1205

Merged
merged 8 commits into from
Oct 15, 2019
Merged

Code style update #1205

merged 8 commits into from
Oct 15, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Oct 9, 2019

No description provided.

@stevenjoezhang stevenjoezhang added this to the v7.4.2 milestone Oct 14, 2019
@stevenjoezhang stevenjoezhang changed the title Optimize backend scripts Code style update Oct 14, 2019
@1v9
Copy link
Member

1v9 commented Oct 14, 2019

About swig-templates json filter and nunjucks dump filter, see:

https://github.com/node-swig/swig-templates/blob/v2.0.3/lib/filters.js#L333-L336

https://github.com/mozilla/nunjucks/blob/v3.2.0/nunjucks/src/filters.js#L127-L131

GitHub
Take a swig of the best template engine for JavaScript. - node-swig/swig-templates
GitHub
A powerful templating engine with inheritance, asynchronous control, and more (jinja2 inspired) - mozilla/nunjucks

@1v9
Copy link
Member

1v9 commented Oct 14, 2019

We can deirectly use JSON.stringify, once some day we switch to nunjucks then use dump.

@1v9
Copy link
Member

1v9 commented Oct 14, 2019

#494 #506

@stevenjoezhang stevenjoezhang merged commit ee28652 into master Oct 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the script branch October 15, 2019 04:28
@1v9 1v9 modified the milestones: v7.5.0, 7.4.22, 7.4.2 Oct 20, 2019
Liam0205 added a commit to Liam0205/hexo-theme-next that referenced this pull request Oct 22, 2019
- Add Google Analytics Pageview (theme-next#1198)

- Make font-size customized only when `theme.font.enable` is true (theme-next#1058)
- Point to different website based on the scheme (theme-next#1202)
- New Valine options (theme-next#1193)
- Improve the style of site-nav (theme-next#1180)

- Code style update (theme-next#1197, theme-next#1205)
- Replace id with class name (theme-next#1209)
- Add lang attribute to article tag when specified in front matter (theme-next#1199)
- Fix compatibility issues with [email protected] (theme-next#1175)
- Optimize the loading of three.js (theme-next#1140)

- New README for NexT (theme-next#1155)

***

For full changes, see the [comparison between v7.4.1 and v7.5.0](theme-next/hexo-theme-next@v7.4.1...v7.5.0)
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants