Theme review notice #26
Conversation
css/admin/theme-review-notice.css
Outdated
| @@ -0,0 +1,18 @@ | |||
| .theme-review-notice .links { | |||
| margin: 10px 0; | |||
There was a problem hiding this comment.
Better give margin .5em 0 for the p tag above by WP
css/admin/theme-review-notice.css
Outdated
|
|
||
| .theme-review-notice .links a.button-primary { | ||
| margin-left: 0; | ||
| } |
There was a problem hiding this comment.
Can be shortened the CSS to
`.notice.updated.theme-review-notice {
padding-right: 40px;
}
.theme-review-notice .links {
margin: 0.5em 0;
}
.theme-review-notice .links a {
margin: 2px;
}
.theme-review-notice .links .dashicons {
line-height: 30px;
}
`
|
|
||
| // Set the installed time in `esteem_theme_installed_time` option table. | ||
| $option = get_option( 'esteem_theme_installed_time' ); | ||
| if ( ! $option ) { |
There was a problem hiding this comment.
line break between other expression and control structure
| */ | ||
| public function esteem_ignore_theme_review_notice_partially() { | ||
|
|
||
| $user_id = get_current_user_id(); |
There was a problem hiding this comment.
Unnecessary use of a variable. Please see Zakra's latest code for detail. You do not need to use a variable here as it is used only once inside this method.
| */ | ||
| public function esteem_theme_rating_notice_enqueue() { | ||
|
|
||
| wp_enqueue_style( 'esteem-theme-review-notice', get_template_directory_uri() . '/css/admin/theme-review-notice.css' ); |
There was a problem hiding this comment.
No need to create separate file and enqueue it for review. You can just create a single CSS file for all admin notice CSS code.
No description provided.