Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Allow multiple operators in Where class for each property #95

Conversation

fernandovargascabrera
Copy link
Contributor

Description

This PR addresses an issue where the Where class in Neogma was not allowing multiple operators per property. This change fixes that omission, enabling the use of multiple operators for each property in the Where class.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

To verify these changes, I performed the following tests:

  • Test for adding two operators to a property

Test Configuration:

  • SDK: Jest
  • Software version: 26
  • Toolchain: super-test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Owner

@themetalfleece themetalfleece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! That's a great improvement 🚀
I've added a couple of comments about merging the conditions to eliminate the need for continue, let me know what do you think :)

src/Queries/Where/Where.ts Outdated Show resolved Hide resolved
src/Queries/Where/Where.ts Outdated Show resolved Hide resolved
@themetalfleece themetalfleece merged commit 100d8f3 into themetalfleece:master Mar 14, 2024
1 check passed
@themetalfleece
Copy link
Owner

Thanks for implementing this, released at v1.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants