Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties to accept Literal. QueryBuilder.set to accept Literal in data #99

Merged

Conversation

chingmunn
Copy link
Contributor

No description provided.

Copy link
Owner

@themetalfleece themetalfleece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for this! I have just a small comment

src/Queries/QueryBuilder/QueryBuilder.ts Outdated Show resolved Hide resolved
@chingmunn
Copy link
Contributor Author

Also, for some context, I'm intending to use this to set properties using a variable from earlier parts of my cypher query (UNWIND and WITH). The proposed changes could introduce the risk of cypher injections. I'm circumventing this by using a Variable class that extends Literal in my project and including sanitisation checks.

@themetalfleece themetalfleece merged commit 1e2cf90 into themetalfleece:master Jun 7, 2024
1 check passed
@themetalfleece
Copy link
Owner

@chingmunn I see, thanks for the info! If you think that neogma can benefit from the Variable class being built-in, let me know. PRs are always welcome too!

I published this to v1.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants