Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes but with defaults and using the same option #2484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JiveDig
Copy link

@JiveDig JiveDig commented Jun 10, 2022

Fixes my part of #2466

A TL;DR quick test to see the bug is to create 2 fields that save to the same option. Make sure a default is set when registering both. Then only update one of the fields. The updated field works but the default does not work for the field that doesn't have a value in the DB yet.

Fixes my part of themeum#2466

A TL;DR quick test to see the bug is to create 2 fields that save to the same option. Make sure a default is set when registering both. Then only update one of the fields. The updated field works but the default does not work for the field that doesn't have a value in the DB yet.
@JiveDig
Copy link
Author

JiveDig commented Jun 10, 2022

Hey y'all. I've manually had this fix in our theme for a few months now and haven't seen or heard of a single issue with it. I think you're safe to merge this and get it into another small update. I keep having to re-add the change in our theme during every Kirki update. I'm pretty confident it's a bug and this is the fix :)

@JiveDig
Copy link
Author

JiveDig commented Jun 10, 2022

Re my commit desc:

Fixes my part of #2466

A TL;DR quick test to see the bug is to create 2 fields that save to the same option. Make sure a default is set when registering both. Then only update one of the fields. The updated field works but the default does not work for the field that doesn't have a value in the DB yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant