-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PHP 8.2 and packages #57
base: master
Are you sure you want to change the base?
Upgrade PHP 8.2 and packages #57
Conversation
roberto-butti
commented
Dec 25, 2022
- upgrade and check with PHP 8.2
- upgrade code using new renderer of Commonmark
- upgrade GitHub Actions workflow
- using Pint with PSR12
- added configuration for cover image (instead of using hardcoded cover.jpg, you can specify a new file name and format, for example, my-cover.png)
Upgrading packages
Update ci.yml
would be great to get this merged. |
Laravel 10 support
And adds support for Laravel v10 Can this be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Will be nice to get this merged 🙌
@themsaid Can you please merge it? |
Good morning Mohamed @themsaid . Thank you! 🙏 Roberto |
I would love to offer my help as well! I love the tool, it has allowed me to publish 5+ books so far 🙏 |
@roberto-butti can you release your fork? It would be amazing to have an installable version. |
@themsaid Any plan to have a quick review of this PR and merge. Thanks |
I'm available to publish the package from the forked repo, but i think is better and fair to wait Mohamed. |
In case someone wants to use the version that @roberto-butti I've added a temporary working version here: https://github.com/thedevdojo/ibis You can install with: I will remove this package when it's no longer necessary and this gets merged in, but until then, you can use this version with the latest version of Laravel 😉 |
Hi Folks, on top of this PR, i created the PHP8.3 Pull request. |