378 - Add Skeletons whenever component is loading or data is being fetched via API #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is gonna be a very valuable change 🚀 |
There was a problem hiding this comment.
This is good But I think, I'd like to do this gradually (not everything at once). First, we could add skeletons at one or two places at max, see how it goes, (any errors or other issues) and then add it in other places.
I think we can close this PR, and I'll open another one. Will cherry-pick commit(s), if needed.
Sorry, I should have communicated this earlier in the issue ticket but I think its fine.
We can cherry-pick commits from this branch, improve that code and open follow up PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378
