🐛 Fix proxy comparison #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bernardbr
approved these changes
May 13, 2024
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Why did you change the compatibility?
There was a problem hiding this comment.
Ok! The breaking change makes sense now with the IsAssignableTo on GetType.
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>netcoreapp3.1;net6.0</TargetFrameworks> | |||
| <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks> | |
| <TargetFrameworks>netcoreapp3.1;net6.0;net7.0;net8.0</TargetFrameworks> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using VO in EF with Lazy, the Equality between VO and your Lazy version were returning FALSE.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Attachments (if appropriate)
Add additional pieces of information like screenshots, issue links, etc.
Definition of Done