Fixing Stylecop issues

references #10
thenucleus · Jun 9, 2019 · 15ddc74 · 15ddc74
1 parent dc32fe6
commit 15ddc74
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 32 deletions.
diff --git a/src/nuclei.nunit.extensions/ChiSquareTest.cs b/src/nuclei.nunit.extensions/ChiSquareTest.cs
@@ -31,12 +31,12 @@ public ChiSquareTest(double expected, ICollection<double> actual, int numberOfCo
         {
             if (expected <= 0.0)
             {
-                throw new ArgumentOutOfRangeException("expected", "The expected value is negative.");
+                throw new ArgumentOutOfRangeException(nameof(expected), "The expected value is negative.");
             }
 
             if (actual == null)
             {
-                throw new ArgumentNullException("actual");
+                throw new ArgumentNullException(nameof(actual));
             }
 
             _degreesOfFreedom = actual.Count - numberOfConstraints;

diff --git a/src/nuclei.nunit.extensions/ExceptionContractVerifier.cs b/src/nuclei.nunit.extensions/ExceptionContractVerifier.cs
@@ -43,7 +43,7 @@ public void HasDefaultConstructor()
             var constructor = typeof(TException).GetConstructor(
                 BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic,
                 null,
-                new Type[0],
+                Array.Empty<Type>(),
                 null);
             Assert.NotNull(constructor);
         }

diff --git a/src/nuclei.nunit.extensions/Gamma.cs b/src/nuclei.nunit.extensions/Gamma.cs
@@ -46,12 +46,12 @@ public static double IncompleteGamma(double a, double x)
         {
             if (x < 0.0)
             {
-                throw new ArgumentOutOfRangeException("x");
+                throw new ArgumentOutOfRangeException(nameof(x));
             }
 
             if (a <= 0.0)
             {
-                throw new ArgumentOutOfRangeException("a");
+                throw new ArgumentOutOfRangeException(nameof(a));
             }
 
             if (x < (a + 1.0))
@@ -82,14 +82,14 @@ private static double IncompleteGammaContinuedFraction(double a, double x)
                 }
             }
 
-            throw new ArgumentOutOfRangeException("a", "Value too large.");
+            throw new ArgumentOutOfRangeException(nameof(a), "Value too large.");
         }
 
         private static double IncompleteGammaSeries(double a, double x)
         {
             if (x < 0.0)
             {
-                throw new ArgumentOutOfRangeException("x");
+                throw new ArgumentOutOfRangeException(nameof(x));
             }
 
             double num = a;
@@ -106,7 +106,7 @@ private static double IncompleteGammaSeries(double a, double x)
                 }
             }
 
-            throw new ArgumentOutOfRangeException("a", "Value too large.");
+            throw new ArgumentOutOfRangeException(nameof(a), "Value too large.");
         }
     }
 }
diff --git a/src/nuclei.nunit.extensions/NotEnoughHashesException.cs b/src/nuclei.nunit.extensions/NotEnoughHashesException.cs
@@ -8,7 +8,6 @@
 using System;
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
-using System.Runtime.Serialization;
 
 namespace Nuclei.Nunit.Extensions
 {
@@ -20,7 +19,6 @@ namespace Nuclei.Nunit.Extensions
     /// project which is licensed under the Apache License 2.0. More information can be found at:
     /// https://code.google.com/p/mb-unit/.
     /// </remarks>
-    [Serializable]
     [SuppressMessage(
         "Microsoft.StyleCop.CSharp.DocumentationRules",
         "SA1600:ElementsMustBeDocumented",
@@ -68,27 +66,5 @@ public NotEnoughHashesException(string message, Exception innerException)
             : base(message, innerException)
         {
         }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="NotEnoughHashesException"/> class.
-        /// </summary>
-        /// <param name="info">
-        ///     The <see cref="T:System.Runtime.Serialization.SerializationInfo"/> that holds the serialized
-        ///     object data about the exception being thrown.
-        /// </param>
-        /// <param name="context">
-        ///     The <see cref="T:System.Runtime.Serialization.StreamingContext"/> that contains contextual
-        ///     information about the source or destination.
-        /// </param>
-        /// <exception cref="T:System.ArgumentNullException">
-        /// The <paramref name="info"/> parameter is null.
-        /// </exception>
-        /// <exception cref="T:System.Runtime.Serialization.SerializationException">
-        /// The class name is null or <see cref="P:System.Exception.HResult"/> is zero (0).
-        /// </exception>
-        private NotEnoughHashesException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        {
-        }
     }
 }