-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify multiplicity parameter in numeric dataset compilation script #11
Comments
Use this check only for the anionic species AtomDB/atomdb/datasets/numeric/__init__.py Lines 126 to 129 in edd4604
For the nautral and cationic species check against: AtomDB/atomdb/datasets/nist/__init__.py Line 79 in edd4604
|
Hey, @gabrielasd I think I can work upon this issue. I need to add the condition to raise error mentioned above for multiplicity parameter of only the anionic specie. We have to first check the multiplicity value of its neutral atom instead of raising the error. For cationic specie we need to check the value of multiplicity of its neutral atom from raw/database_beta_1.3.0.h5 this file. |
Hi @Aditish51, thanks for expressing interest in contributing to our project. For a given atomic species, which in our project is determined by the element name, its charge and multiplicity, the compilation scripts need to verify that the multiplicity value passed by the user is correct (meaning corresponds to the most stable electronic configuration). This was not being done in the case of the numeric database. As you noticed, there is already a partial fix to this issue in PR #24, where for a given element and charge, one determines the number of electrons and looks in the MULTIPLICITY table what should be the corresponding multiplicity. If the input The a better procedure that can be followed is: |
Hi @gabrielasd Thanks for all of the information you provided. I tried to understand the issue well and arrived at a solution that the |
This issue is solved by PR #36 |
The function that retrieves the data from the numeric Hartree-Fock computations, only requires the atomic number and number of electrons as parameters. This assumes that the atomic species is the most stable one for the given atom and charge, but there is no specification for the multiplicity. Therefore an incorrect multiplicity for the retrieved data may be passed as input:
AtomDB/atomdb/datasets/numeric/__init__.py
Line 95 in 85031c5
Use NIST data to assign the reference mult value based on the ground state for the element/number of electrons.
Highly charged species may require taking the ground state of the corresponding isolelectronic specie.
The text was updated successfully, but these errors were encountered: