Fix log density spline extrapolation #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulWAyers
requested changes
Dec 10, 2024
PaulWAyers
approved these changes
Dec 11, 2024
msricher
force-pushed
the
fix_extrapolate
branch
from
7d1cf52 to
6b8966e
Compare
marco-2023
reviewed
Dec 16, 2024
| np.log(y) if log else y, | ||
| # Clip y values to >=ε^2 if using log because they have to be above 0; | ||
| # having them be at least ε^2 seems to work based on my testing | ||
| np.log(y.clip(min=np.finfo(float).eps ** 2)) if log else y, |
There was a problem hiding this comment.
@PaulWAyers and @msricher I have a doubt, for all the features that we describe as splines, for values of r outside our array of values, the spline is a polynomial that will diverge for
marco-2023
approved these changes
Dec 16, 2024
msricher
force-pushed
the
fix_extrapolate
branch
from
f15d93e to
a2653e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.